Browse Source

win: fix ObjectWrap for latest v8

We need to keep ObjectWrap around for module authors (we think), but
v8 3.21 broke node_object_wrap.h with respect to MSVC. Coincidentally,
we no longer use ObjectWrap at all in core, and native modules might
as well use their own entirely internal implementation if they need it.
v0.11.8-release
Scott Blomquist 11 years ago
committed by Trevor Norris
parent
commit
7a7101ac9b
  1. 11
      src/node_object_wrap.h

11
src/node_object_wrap.h

@ -22,22 +22,13 @@
#ifndef SRC_NODE_OBJECT_WRAP_H_ #ifndef SRC_NODE_OBJECT_WRAP_H_
#define SRC_NODE_OBJECT_WRAP_H_ #define SRC_NODE_OBJECT_WRAP_H_
#include "node.h"
#include "v8.h" #include "v8.h"
#include <assert.h> #include <assert.h>
// Explicitly instantiate some template classes, so we're sure they will be
// present in the binary / shared object. There isn't much doubt that they will
// be, but MSVC tends to complain about these things.
#ifdef _MSC_VER
template class NODE_EXTERN v8::Persistent<v8::Object>;
template class NODE_EXTERN v8::Persistent<v8::FunctionTemplate>;
#endif
namespace node { namespace node {
class NODE_EXTERN ObjectWrap { class ObjectWrap {
public: public:
ObjectWrap() { ObjectWrap() {
refs_ = 0; refs_ = 0;

Loading…
Cancel
Save