Browse Source

build,win: fix node.exe resource version

When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but
passes it correctly to cl.exe. Hence, this workaround was made to
apply only to the resource file.

Fixes: https://github.com/nodejs/node/issues/2963
PR-URL: https://github.com/nodejs/node/pull/3053
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
v0.12-staging
João Reis 10 years ago
committed by Rod Vagg
parent
commit
7e4b47f38a
  1. 4
      src/res/node.rc

4
src/res/node.rc

@ -53,8 +53,8 @@ BEGIN
VALUE "CompanyName", "Joyent, Inc" VALUE "CompanyName", "Joyent, Inc"
VALUE "ProductName", "Node.js" VALUE "ProductName", "Node.js"
VALUE "FileDescription", "Evented I/O for V8 JavaScript" VALUE "FileDescription", "Evented I/O for V8 JavaScript"
VALUE "FileVersion", NODE_VERSION_STRING VALUE "FileVersion", NODE_EXE_VERSION
VALUE "ProductVersion", NODE_VERSION_STRING VALUE "ProductVersion", NODE_EXE_VERSION
VALUE "OriginalFilename", "node.exe" VALUE "OriginalFilename", "node.exe"
VALUE "InternalName", "node" VALUE "InternalName", "node"
VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license." VALUE "LegalCopyright", "Copyright Joyent, Inc. and other Node contributors. MIT license."

Loading…
Cancel
Save