From 837df70b7576089f808ab3acf626cb06e430f4f6 Mon Sep 17 00:00:00 2001
From: Nathan Rajlich <nathan@tootallnate.net>
Date: Fri, 21 Dec 2012 11:42:40 -0800
Subject: [PATCH] repl: don't touch `require.cache`

Fixes #3226.

Consider a production server that uses a REPL to debug. Creating the instance
would wipe out the global cache of modules, and subsequent "require" calls in
the server would be reloaded from disk. The REPL should observe only, without
altering, its environment.
---
 lib/repl.js                            |  1 -
 test/simple/test-repl-require-cache.js | 33 ++++++++++++++++++++++++++
 2 files changed, 33 insertions(+), 1 deletion(-)
 create mode 100644 test/simple/test-repl-require-cache.js

diff --git a/lib/repl.js b/lib/repl.js
index 3438a45cc1..556ccd93a6 100644
--- a/lib/repl.js
+++ b/lib/repl.js
@@ -346,7 +346,6 @@ REPLServer.prototype.createContext = function() {
 };
 
 REPLServer.prototype.resetContext = function() {
-  for (var i in require.cache) delete require.cache[i];
   this.context = this.createContext();
 };
 
diff --git a/test/simple/test-repl-require-cache.js b/test/simple/test-repl-require-cache.js
new file mode 100644
index 0000000000..ea2d6d6bd9
--- /dev/null
+++ b/test/simple/test-repl-require-cache.js
@@ -0,0 +1,33 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+var common = require('../common'),
+    assert = require('assert'),
+    repl = require('repl');
+
+// https://github.com/joyent/node/issues/3226
+
+require.cache.something = 1;
+assert.equal(require.cache.something, 1);
+
+repl.start({ useGlobal: false }).rli.close();
+
+assert.equal(require.cache.something, 1);