From 84c448eafbbf968241bc72b5020081fcc0ebc522 Mon Sep 17 00:00:00 2001 From: Arseniy Maximov Date: Thu, 23 Feb 2017 02:46:32 +0300 Subject: [PATCH] net: prefer === to == * Change === to == in one place * Add explanation about another non-strict if-statement PR-URL: https://github.com/nodejs/node/pull/11513 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig --- lib/net.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/net.js b/lib/net.js index 1213098953..0aa087ad7e 100644 --- a/lib/net.js +++ b/lib/net.js @@ -146,6 +146,9 @@ function Socket(options) { } else if (options.fd !== undefined) { this._handle = createHandle(options.fd); this._handle.open(options.fd); + // options.fd can be string (since it user-defined), + // so changing this to === would be semver-major + // See: https://github.com/nodejs/node/pull/11513 if ((options.fd == 1 || options.fd == 2) && (this._handle instanceof Pipe) && process.platform === 'win32') { @@ -1069,7 +1072,7 @@ function afterConnect(status, handle, req, readable, writable) { self.connecting = false; self._sockname = null; - if (status == 0) { + if (status === 0) { self.readable = readable; self.writable = writable; self._unrefTimer();