From 84f9261efd02c7e4ddb087cadf528b2aaed8809c Mon Sep 17 00:00:00 2001 From: Andreas Madsen Date: Sun, 2 Jul 2017 17:20:31 +0200 Subject: [PATCH] async_hooks: require parameter in emitBefore Using asyncId as the default triggerAsyncId is wrong. The triggerAsyncId can actually never be the asyncId. PR-URL: https://github.com/nodejs/node/pull/14050 Reviewed-By: Trevor Norris Reviewed-By: Anna Henningsen --- lib/async_hooks.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/async_hooks.js b/lib/async_hooks.js index 54db3ec85d..ebbd284c00 100644 --- a/lib/async_hooks.js +++ b/lib/async_hooks.js @@ -377,7 +377,7 @@ function emitHookFactory(symbol, name) { // Usage: emitBeforeS(asyncId[, triggerAsyncId]). If triggerAsyncId is omitted // then asyncId will be used instead. -function emitBeforeS(asyncId, triggerAsyncId = asyncId) { +function emitBeforeS(asyncId, triggerAsyncId) { // CHECK(Number.isSafeInteger(asyncId) && asyncId > 0) // CHECK(Number.isSafeInteger(triggerAsyncId) && triggerAsyncId > 0)