Browse Source

doc: add optional step to onboarding doc

Include information on how to force push to the contributor's own branch
so that pull requests show as merged in GitHub interface.

PR-URL: https://github.com/nodejs/node/pull/8774
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
v7.x
Rich Trott 8 years ago
committed by James M Snell
parent
commit
87001f1e3a
  1. 1
      doc/onboarding.md

1
doc/onboarding.md

@ -184,6 +184,7 @@ Landing a PR
* This will automatically close the PR when the commit lands in master. * This will automatically close the PR when the commit lands in master.
* `Refs: <full-url>` * `Refs: <full-url>`
* Full URL of material that might provide additional useful information or context to someone trying to understand the change set or the thinking behind it. * Full URL of material that might provide additional useful information or context to someone trying to understand the change set or the thinking behind it.
* Optional: Force push the amended commit to the branch you used to open the pull request. If your branch is called `bugfix`, then the command would be `git push --force-with-lease origin master:bugfix`. When the pull request is closed, this will cause the pull request to show the purple merged status rather than the red closed status that is usually used for pull requests that weren't merged. Only do this when landing your own contributions.
* `git push upstream master` * `git push upstream master`
* Close the pull request with a "Landed in `<commit hash>`" comment. * Close the pull request with a "Landed in `<commit hash>`" comment.

Loading…
Cancel
Save