From 87405b0d98e5f96eec1bd3ddfea6fe4ad2489892 Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Sun, 25 Aug 2013 18:44:57 +0200 Subject: [PATCH] process_wrap: don't coerce process exit code to int32_t On windows process exit codes can be greater than INT32_MAX. This used to be not much of a problem - greater values would just come out negative. However since ca9eb71 a negative result value indicates that uv_spawn() has failed, so this is no longer acceptable. --- src/process_wrap.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/process_wrap.cc b/src/process_wrap.cc index 2dbfdfb30f..aebed822e7 100644 --- a/src/process_wrap.cc +++ b/src/process_wrap.cc @@ -275,7 +275,7 @@ class ProcessWrap : public HandleWrap { assert(&wrap->process_ == handle); Local argv[] = { - Integer::New(exit_status, node_isolate), + Number::New(node_isolate, static_cast(exit_status)), OneByteString(node_isolate, signo_string(term_signal)) };