From 89285db1284ecf2e2be9d5c7da9f8488aecbd4b7 Mon Sep 17 00:00:00 2001 From: Andres Suarez Date: Wed, 28 Oct 2015 17:12:35 -0700 Subject: [PATCH] module: remove unnecessary JSON.stringify `debuglog` uses `%j` as a placeholder for replacement with `JSON.stringify`. So that `JSON.stringify` is only called when the appropriate debug flag is on. The other `%s` changes are for style consistency. PR-URL: https://github.com/nodejs/node/pull/3578 Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Evan Lucas Reviewed-By: James M Snell Reviewed-By: Colin Ihrig --- lib/module.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/module.js b/lib/module.js index ef0fad209f..0da2398ba6 100644 --- a/lib/module.js +++ b/lib/module.js @@ -254,8 +254,8 @@ Module._resolveLookupPaths = function(request, parent) { id = './' + id; } - debug('RELATIVE: requested:' + request + - ' set ID to: ' + id + ' from ' + parent.id); + debug('RELATIVE: requested: %s set ID to: %s from %s', request, id, + parent.id); return [id, [path.dirname(parent.filename)]]; }; @@ -270,7 +270,7 @@ Module._resolveLookupPaths = function(request, parent) { // object. Module._load = function(request, parent, isMain) { if (parent) { - debug('Module._load REQUEST ' + (request) + ' parent: ' + parent.id); + debug('Module._load REQUEST %s parent: %s', request, parent.id); } // REPL is a special case, because it needs the real require. @@ -292,7 +292,7 @@ Module._load = function(request, parent, isMain) { } if (NativeModule.nonInternalExists(filename)) { - debug('load native module ' + request); + debug('load native module %s', request); return NativeModule.require(filename); } @@ -329,8 +329,7 @@ Module._resolveFilename = function(request, parent) { var paths = resolvedModule[1]; // look up the filename first, since that's the cache key. - debug('looking for ' + JSON.stringify(id) + - ' in ' + JSON.stringify(paths)); + debug('looking for %j in %j', id, paths); var filename = Module._findPath(request, paths); if (!filename) { @@ -344,8 +343,7 @@ Module._resolveFilename = function(request, parent) { // Given a file name, pass it to the proper extension handler. Module.prototype.load = function(filename) { - debug('load ' + JSON.stringify(filename) + - ' for module ' + JSON.stringify(this.id)); + debug('load %j for module %j', filename, this.id); assert(!this.loaded); this.filename = filename;