From 8a83ebaede7591e7bd3745d0ca27ecde2531b100 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 7 Jan 2015 19:05:33 +0100 Subject: [PATCH] build: fix up build after v8 upgrade * Define and disable new flag `v8_use_external_startup_data`. * Disable v8_postmortem_support, it's broken again. Fedor (@indutny) has volunteered to fix it up in the near future. PR-URL: https://github.com/iojs/io.js/pull/243 Reviewed-By: Fedor Indutny Reviewed-By: Trevor Norris --- common.gypi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/common.gypi b/common.gypi index fd436a5bce..f8cc82ce0d 100644 --- a/common.gypi +++ b/common.gypi @@ -20,14 +20,17 @@ # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, - # Enable V8's post-mortem debugging only on unix flavors. + # Don't bake anything extra into the snapshot. + 'v8_use_external_startup_data%': 0, + + # Disable V8's post-mortem debugging; frequently broken and hardly used. + 'v8_postmortem_support%': 'false', + 'conditions': [ ['OS == "win"', { 'os_posix': 0, - 'v8_postmortem_support': 'false' }, { 'os_posix': 1, - 'v8_postmortem_support': 'true' }], ['GENERATOR == "ninja" or OS== "mac"', { 'OBJ_DIR': '<(PRODUCT_DIR)/obj',