Browse Source

udp: remove a needless instanceof Buffer check

When a string is passed to udpsock.send, it is automatically
converted to a Buffer. In that case, it is no longer needed
to test whether or not the argument is a Buffer or not.

PR-URL: https://github.com/nodejs/node/pull/4301
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Roman Reiss <me@silverwind.io>

Conflicts:
	lib/dgram.js
v5.x
ronkorving 9 years ago
committed by cjihrig
parent
commit
8c7b0cc977
  1. 5
      lib/dgram.js

5
lib/dgram.js

@ -252,9 +252,8 @@ Socket.prototype.send = function(buffer,
if (typeof buffer === 'string')
buffer = new Buffer(buffer);
if (!(buffer instanceof Buffer))
throw new TypeError('First argument must be a buffer or string.');
else if (!(buffer instanceof Buffer))
throw new TypeError('First argument must be a buffer or string');
offset = offset | 0;
if (offset < 0)

Loading…
Cancel
Save