From 8cf94006c9d220e65f11a81ac10404d277294bac Mon Sep 17 00:00:00 2001 From: Ali Ijaz Sheikh Date: Mon, 29 Feb 2016 17:08:36 -0800 Subject: [PATCH] build: do not ignore errors during build-addons MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Errors during build-addons were being silently ignored. PR-URL: https://github.com/nodejs/node/pull/5494 Reviewed-By: bnoordhuis - Ben Noordhuis Reviewed-By: targos - Michaƫl Zasso --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 221dd74e9d..120d8512bf 100644 --- a/Makefile +++ b/Makefile @@ -144,7 +144,7 @@ test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp for dirname in test/addons/*/; do \ $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ --directory="$$PWD/$$dirname" \ - --nodedir="$$PWD"; \ + --nodedir="$$PWD" || exit 1 ; \ done touch $@