From 9004bfe55060fc39e9f35efd99283242f6bd2949 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Wed, 9 Nov 2016 21:02:14 -0800
Subject: [PATCH] test: refactor test-tls-inception
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* buffer-to-string comparison replaced with string-to-string comparison
* equal -> strictEqual
* var -> const
* rename identifiers to avoid masking

PR-URL: https://github.com/nodejs/node/pull/9536
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
---
 test/parallel/test-tls-inception.js | 36 ++++++++++++++---------------
 1 file changed, 17 insertions(+), 19 deletions(-)

diff --git a/test/parallel/test-tls-inception.js b/test/parallel/test-tls-inception.js
index ce6f60dc97..760887d9f2 100644
--- a/test/parallel/test-tls-inception.js
+++ b/test/parallel/test-tls-inception.js
@@ -1,34 +1,33 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
+const common = require('../common');
 
 if (!common.hasCrypto) {
   common.skip('missing crypto');
   return;
 }
-var tls = require('tls');
 
-var fs = require('fs');
-var path = require('path');
-var net = require('net');
+const assert = require('assert');
+const tls = require('tls');
 
-var options, a, b;
+const fs = require('fs');
+const path = require('path');
+const net = require('net');
 
-var body = Buffer.alloc(400000, 'A');
-
-options = {
+const options = {
   key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')),
   cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'))
 };
 
+const body = 'A'.repeat(40000);
+
 // the "proxy" server
-a = tls.createServer(options, function(socket) {
-  var options = {
+const a = tls.createServer(options, function(socket) {
+  const myOptions = {
     host: '127.0.0.1',
     port: b.address().port,
     rejectUnauthorized: false
   };
-  var dest = net.connect(options);
+  const dest = net.connect(myOptions);
   dest.pipe(socket);
   socket.pipe(dest);
 
@@ -38,20 +37,19 @@ a = tls.createServer(options, function(socket) {
 });
 
 // the "target" server
-b = tls.createServer(options, function(socket) {
+const b = tls.createServer(options, function(socket) {
   socket.end(body);
 });
 
 a.listen(0, function() {
   b.listen(0, function() {
-    options = {
+    const myOptions = {
       host: '127.0.0.1',
       port: a.address().port,
       rejectUnauthorized: false
     };
-    var socket = tls.connect(options);
-    var ssl;
-    ssl = tls.connect({
+    const socket = tls.connect(myOptions);
+    const ssl = tls.connect({
       socket: socket,
       rejectUnauthorized: false
     });
@@ -61,7 +59,7 @@ a.listen(0, function() {
       buf += data;
     });
     ssl.on('end', common.mustCall(function() {
-      assert.equal(buf, body);
+      assert.strictEqual(buf, body);
       ssl.end();
       a.close();
       b.close();