From 931cbc175f7664d785e6a59642b07471851826fb Mon Sep 17 00:00:00 2001 From: Jackson Tian Date: Mon, 11 Aug 2014 16:41:18 +0800 Subject: [PATCH] lib: don't use emitter.listeners(type).length Reviewed-by: Trevor Norris --- lib/_tls_wrap.js | 9 +++++---- src/node.js | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js index 48cbbf89d7..91917b6a5f 100644 --- a/lib/_tls_wrap.js +++ b/lib/_tls_wrap.js @@ -27,6 +27,7 @@ var crypto = require('crypto'); var net = require('net'); var tls = require('tls'); var util = require('util'); +var listenerCount = require('events').listenerCount; var common = require('_tls_common'); var Timer = process.binding('timer_wrap').Timer; @@ -131,7 +132,7 @@ function requestOCSP(self, hello, ctx, cb) { if (ctx.context) ctx = ctx.context; - if (self.server.listeners('OCSPRequest').length === 0) { + if (listenerCount(self.server, 'OCSPRequest') === 0) { return cb(null); } else { self.server.emit('OCSPRequest', @@ -311,9 +312,9 @@ TLSSocket.prototype._init = function(socket) { this.ssl.handshakes = 0; if (this.server && - (this.server.listeners('resumeSession').length > 0 || - this.server.listeners('newSession').length > 0 || - this.server.listeners('OCSPRequest').length > 0)) { + (listenerCount(this.server, 'resumeSession') > 0 || + listenerCount(this.server, 'newSession') > 0 || + listenerCount(this.server, 'OCSPRequest') > 0)) { this.ssl.enableSessionCallbacks(); } } else { diff --git a/src/node.js b/src/node.js index 0c17376486..aebe683d3f 100644 --- a/src/node.js +++ b/src/node.js @@ -670,7 +670,7 @@ if (isSignal(type)) { assert(signalWraps.hasOwnProperty(type)); - if (this.listeners(type).length === 0) { + if (EventEmitter.listenerCount(this, type) === 0) { signalWraps[type].close(); delete signalWraps[type]; }