Browse Source

url: treat \ the same as /

See https://code.google.com/p/chromium/issues/detail?id=25916

Parse URLs with backslashes the same as web browsers, by replacing all
backslashes with forward slashes, except those that occur after the
first # character.
v0.10.27-release
isaacs 11 years ago
parent
commit
9520adeb37
  1. 6
      lib/url.js
  2. 26
      test/simple/test-url.js

6
lib/url.js

@ -107,6 +107,12 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost) {
throw new TypeError("Parameter 'url' must be a string, not " + typeof url);
}
// Copy chrome, IE, opera backslash-handling behavior.
// See: https://code.google.com/p/chromium/issues/detail?id=25916
var hashSplit = url.split('#');
hashSplit[0] = hashSplit[0].replace(/\\/g, '/');
url = hashSplit.join('#');
var rest = url;
// trim before proceeding.

26
test/simple/test-url.js

@ -34,6 +34,28 @@ var parseTests = {
'path': '//some_path'
},
'http:\\\\evil-phisher\\foo.html#h\\a\\s\\h': {
protocol: 'http:',
slashes: true,
host: 'evil-phisher',
hostname: 'evil-phisher',
pathname: '/foo.html',
path: '/foo.html',
hash: '#h\\a\\s\\h',
href: 'http://evil-phisher/foo.html#h\\a\\s\\h'
},
'http:\\\\evil-phisher\\foo.html': {
protocol: 'http:',
slashes: true,
host: 'evil-phisher',
hostname: 'evil-phisher',
pathname: '/foo.html',
path: '/foo.html',
href: 'http://evil-phisher/foo.html'
},
'HTTP://www.example.com/' : {
'href': 'http://www.example.com/',
'protocol': 'http:',
@ -1457,3 +1479,7 @@ relativeTests2.forEach(function(relativeTest) {
'format(' + relativeTest[1] + ') == ' + expected +
'\nactual:' + actual);
});
// backslashes should be like forward slashes
var res = url.resolve('http://example.com/x', '\\\\foo.com\\bar');
assert.equal(res, 'http://foo.com/bar');

Loading…
Cancel
Save