From 953b049a89f803b0a152e776b8590e78ada180e4 Mon Sep 17 00:00:00 2001 From: Scott Blomquist Date: Thu, 25 Oct 2012 16:51:46 -0700 Subject: [PATCH] windows: correct outputs list in "node_etw" gyp target The gyp target node_etw didn't list its output dependencies. This was causing virgin builds to fail with a "failed to open file for write" error. With this corrected outputs list, gyp reliably pre-creates required output directories. --- node.gyp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/node.gyp b/node.gyp index 939870a561..c7928d6787 100644 --- a/node.gyp +++ b/node.gyp @@ -253,8 +253,11 @@ { 'action_name': 'node_etw', 'inputs': [ 'src/res/node_etw_provider.man' ], - 'outputs': [ '<(SHARED_INTERMEDIATE_DIR)' ], - 'action': [ 'mc <@(_inputs) -h <@(_outputs) -r <@(_outputs)' ] + 'outputs': [ + '<(SHARED_INTERMEDIATE_DIR)/node_etw_provider.rc', + '<(SHARED_INTERMEDIATE_DIR)/node_etw_provider.h', + ], + 'action': [ 'mc <@(_inputs) -h <(SHARED_INTERMEDIATE_DIR) -r <(SHARED_INTERMEDIATE_DIR)' ] } ] } ]