From 9a6e253d32d430cf3184051103ad6636d60a6505 Mon Sep 17 00:00:00 2001 From: yorkie Date: Sat, 17 Sep 2016 17:20:26 +0800 Subject: [PATCH] src: remove unneeded ABORT after CHECK CHECK includes node::Abort(), so that's unneeded to call ABORT after CHECK. PR-URL: https://github.com/nodejs/node/pull/8593 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen --- src/cares_wrap.cc | 2 -- src/fs_event_wrap.cc | 1 - src/node_crypto_bio.cc | 1 - 3 files changed, 4 deletions(-) diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index 186f542cec..8ceec9d5af 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -1135,7 +1135,6 @@ static void GetAddrInfo(const FunctionCallbackInfo& args) { break; default: CHECK(0 && "bad address family"); - ABORT(); } GetAddrInfoReqWrap* req_wrap = new GetAddrInfoReqWrap(env, req_wrap_obj); @@ -1261,7 +1260,6 @@ static void SetServers(const FunctionCallbackInfo& args) { break; default: CHECK(0 && "Bad address family."); - ABORT(); } if (err) diff --git a/src/fs_event_wrap.cc b/src/fs_event_wrap.cc index 64ff93e257..025f511d93 100644 --- a/src/fs_event_wrap.cc +++ b/src/fs_event_wrap.cc @@ -155,7 +155,6 @@ void FSEventWrap::OnEvent(uv_fs_event_t* handle, const char* filename, event_string = env->change_string(); } else { CHECK(0 && "bad fs events flag"); - ABORT(); } Local argv[] = { diff --git a/src/node_crypto_bio.cc b/src/node_crypto_bio.cc index ec4aa69b07..a862573c28 100644 --- a/src/node_crypto_bio.cc +++ b/src/node_crypto_bio.cc @@ -189,7 +189,6 @@ long NodeBIO::Ctrl(BIO* bio, int cmd, long num, // NOLINT(runtime/int) break; case BIO_C_SET_BUF_MEM: CHECK(0 && "Can't use SET_BUF_MEM_PTR with NodeBIO"); - ABORT(); break; case BIO_C_GET_BUF_MEM_PTR: CHECK(0 && "Can't use GET_BUF_MEM_PTR with NodeBIO");