mirror of https://github.com/lukechilds/node.git
Browse Source
This helps to prevent issues where a failed test can keep a bound socket open long enough to cause other tests to fail with EADDRINUSE because the same port number is used. PR-URL: https://github.com/nodejs/node/pull/7045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>v4.x
Brian White
9 years ago
committed by
Myles Borins
Myles Borins
336 changed files with 1514 additions and 1478 deletions
@ -1,86 +1,86 @@ |
|||||
'use strict'; |
'use strict'; |
||||
var common = require('../common'); |
require('../common'); |
||||
var assert = require('assert'); |
var assert = require('assert'); |
||||
var http = require('http'); |
var http = require('http'); |
||||
|
|
||||
var server = http.createServer(function(req, res) { |
var server = http.createServer(function(req, res) { |
||||
res.writeHead(200, {'Content-Type': 'text/plain'}); |
res.writeHead(200, {'Content-Type': 'text/plain'}); |
||||
res.end('Hello World\n'); |
res.end('Hello World\n'); |
||||
}).listen(common.PORT); |
}).listen(0, function() { |
||||
|
var agent = new http.Agent({maxSockets: 1}); |
||||
|
|
||||
var agent = new http.Agent({maxSockets: 1}); |
agent.on('free', function(socket, host, port) { |
||||
|
console.log('freeing socket. destroyed? ', socket.destroyed); |
||||
agent.on('free', function(socket, host, port) { |
}); |
||||
console.log('freeing socket. destroyed? ', socket.destroyed); |
|
||||
}); |
|
||||
|
|
||||
var requestOptions = { |
var requestOptions = { |
||||
agent: agent, |
agent: agent, |
||||
host: 'localhost', |
host: 'localhost', |
||||
port: common.PORT, |
port: this.address().port, |
||||
path: '/' |
path: '/' |
||||
}; |
}; |
||||
|
|
||||
var request1 = http.get(requestOptions, function(response) { |
var request1 = http.get(requestOptions, function(response) { |
||||
// assert request2 is queued in the agent
|
// assert request2 is queued in the agent
|
||||
var key = agent.getName(requestOptions); |
var key = agent.getName(requestOptions); |
||||
assert(agent.requests[key].length === 1); |
assert(agent.requests[key].length === 1); |
||||
console.log('got response1'); |
console.log('got response1'); |
||||
request1.socket.on('close', function() { |
request1.socket.on('close', function() { |
||||
console.log('request1 socket closed'); |
console.log('request1 socket closed'); |
||||
}); |
}); |
||||
response.pipe(process.stdout); |
response.pipe(process.stdout); |
||||
response.on('end', function() { |
response.on('end', function() { |
||||
console.log('response1 done'); |
console.log('response1 done'); |
||||
/////////////////////////////////
|
/////////////////////////////////
|
||||
//
|
//
|
||||
// THE IMPORTANT PART
|
// THE IMPORTANT PART
|
||||
//
|
//
|
||||
// It is possible for the socket to get destroyed and other work
|
// It is possible for the socket to get destroyed and other work
|
||||
// to run before the 'close' event fires because it happens on
|
// to run before the 'close' event fires because it happens on
|
||||
// nextTick. This example is contrived because it destroys the
|
// nextTick. This example is contrived because it destroys the
|
||||
// socket manually at just the right time, but at Voxer we have
|
// socket manually at just the right time, but at Voxer we have
|
||||
// seen cases where the socket is destroyed by non-user code
|
// seen cases where the socket is destroyed by non-user code
|
||||
// then handed out again by an agent *before* the 'close' event
|
// then handed out again by an agent *before* the 'close' event
|
||||
// is triggered.
|
// is triggered.
|
||||
request1.socket.destroy(); |
request1.socket.destroy(); |
||||
|
|
||||
response.once('close', function() { |
response.once('close', function() { |
||||
// assert request2 was removed from the queue
|
// assert request2 was removed from the queue
|
||||
assert(!agent.requests[key]); |
assert(!agent.requests[key]); |
||||
console.log("waiting for request2.onSocket's nextTick"); |
console.log("waiting for request2.onSocket's nextTick"); |
||||
process.nextTick(function() { |
process.nextTick(function() { |
||||
// assert that the same socket was not assigned to request2,
|
// assert that the same socket was not assigned to request2,
|
||||
// since it was destroyed.
|
// since it was destroyed.
|
||||
assert(request1.socket !== request2.socket); |
assert(request1.socket !== request2.socket); |
||||
assert(!request2.socket.destroyed, 'the socket is destroyed'); |
assert(!request2.socket.destroyed, 'the socket is destroyed'); |
||||
|
}); |
||||
}); |
}); |
||||
}); |
}); |
||||
}); |
}); |
||||
}); |
|
||||
|
|
||||
var request2 = http.get(requestOptions, function(response) { |
var request2 = http.get(requestOptions, function(response) { |
||||
assert(!request2.socket.destroyed); |
assert(!request2.socket.destroyed); |
||||
assert(request1.socket.destroyed); |
assert(request1.socket.destroyed); |
||||
// assert not reusing the same socket, since it was destroyed.
|
// assert not reusing the same socket, since it was destroyed.
|
||||
assert(request1.socket !== request2.socket); |
assert(request1.socket !== request2.socket); |
||||
console.log('got response2'); |
console.log('got response2'); |
||||
var gotClose = false; |
var gotClose = false; |
||||
var gotResponseEnd = false; |
var gotResponseEnd = false; |
||||
request2.socket.on('close', function() { |
request2.socket.on('close', function() { |
||||
console.log('request2 socket closed'); |
console.log('request2 socket closed'); |
||||
gotClose = true; |
gotClose = true; |
||||
done(); |
done(); |
||||
}); |
}); |
||||
response.pipe(process.stdout); |
response.pipe(process.stdout); |
||||
response.on('end', function() { |
response.on('end', function() { |
||||
console.log('response2 done'); |
console.log('response2 done'); |
||||
gotResponseEnd = true; |
gotResponseEnd = true; |
||||
done(); |
done(); |
||||
}); |
}); |
||||
|
|
||||
function done() { |
function done() { |
||||
if (gotResponseEnd && gotClose) |
if (gotResponseEnd && gotClose) |
||||
server.close(); |
server.close(); |
||||
} |
} |
||||
|
}); |
||||
}); |
}); |
||||
|
|||||
Some files were not shown because too many files changed in this diff
Loading…
Reference in new issue