mirror of https://github.com/lukechilds/node.git
Browse Source
The idea here is to reduce the number of times that `setRawMode()` is called on the `input` stream, since it is expensive, and simply pause()/resume() should not call it. So now `setRawMode()` only gets called at the beginning of the Interface instance, and then when `Interface#close()` is called. Test case included.v0.9.1-release
Nathan Rajlich
13 years ago
2 changed files with 104 additions and 13 deletions
@ -0,0 +1,87 @@ |
|||||
|
// Copyright Joyent, Inc. and other Node contributors.
|
||||
|
//
|
||||
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
||||
|
// copy of this software and associated documentation files (the
|
||||
|
// "Software"), to deal in the Software without restriction, including
|
||||
|
// without limitation the rights to use, copy, modify, merge, publish,
|
||||
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
||||
|
// persons to whom the Software is furnished to do so, subject to the
|
||||
|
// following conditions:
|
||||
|
//
|
||||
|
// The above copyright notice and this permission notice shall be included
|
||||
|
// in all copies or substantial portions of the Software.
|
||||
|
//
|
||||
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
||||
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
||||
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
||||
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
||||
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
||||
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
||||
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
||||
|
|
||||
|
|
||||
|
|
||||
|
var assert = require('assert'); |
||||
|
var readline = require('readline'); |
||||
|
var Stream = require('stream'); |
||||
|
|
||||
|
var stream = new Stream(); |
||||
|
var expectedRawMode = true; |
||||
|
var rawModeCalled = false; |
||||
|
var resumeCalled = false; |
||||
|
var pauseCalled = false; |
||||
|
|
||||
|
stream.setRawMode = function(mode) { |
||||
|
rawModeCalled = true; |
||||
|
assert.equal(mode, expectedRawMode); |
||||
|
}; |
||||
|
stream.resume = function() { |
||||
|
resumeCalled = true; |
||||
|
}; |
||||
|
stream.pause = function() { |
||||
|
pauseCalled = true; |
||||
|
}; |
||||
|
|
||||
|
// when the "readline" starts in "terminal" mode,
|
||||
|
// then setRawMode(true) should be called
|
||||
|
var rli = readline.createInterface({ |
||||
|
input: stream, |
||||
|
output: stream, |
||||
|
terminal: true |
||||
|
}); |
||||
|
assert(rli.terminal) |
||||
|
assert(rawModeCalled); |
||||
|
assert(resumeCalled); |
||||
|
assert(!pauseCalled); |
||||
|
|
||||
|
|
||||
|
// pause() should call *not* call setRawMode()
|
||||
|
rawModeCalled = false; |
||||
|
resumeCalled = false; |
||||
|
pauseCalled = false; |
||||
|
rli.pause(); |
||||
|
assert(!rawModeCalled); |
||||
|
assert(!resumeCalled); |
||||
|
assert(pauseCalled); |
||||
|
|
||||
|
|
||||
|
// resume() should *not* call setRawMode()
|
||||
|
rawModeCalled = false; |
||||
|
resumeCalled = false; |
||||
|
pauseCalled = false; |
||||
|
rli.resume(); |
||||
|
assert(!rawModeCalled); |
||||
|
assert(resumeCalled); |
||||
|
assert(!pauseCalled); |
||||
|
|
||||
|
|
||||
|
// close() should call setRawMode(false)
|
||||
|
expectedRawMode = false; |
||||
|
rawModeCalled = false; |
||||
|
resumeCalled = false; |
||||
|
pauseCalled = false; |
||||
|
rli.close(); |
||||
|
assert(rawModeCalled); |
||||
|
assert(!resumeCalled); |
||||
|
assert(pauseCalled); |
||||
|
|
Loading…
Reference in new issue