From 9ce888274c77e1b91161656e75e990faf9ef548f Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 10 Jun 2016 11:33:14 +0200 Subject: [PATCH] test: rebuild add-ons when their sources change The prerequisite for rebuilding was on the binding.gyp file but the actual sources. PR-URL: https://github.com/nodejs/node/pull/7262 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Trevor Norris --- Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index cf10346a21..c44ed79345 100644 --- a/Makefile +++ b/Makefile @@ -143,11 +143,15 @@ ADDONS_BINDING_GYPS := \ $(filter-out test/addons/??_*/binding.gyp, \ $(wildcard test/addons/*/binding.gyp)) +ADDONS_BINDING_SOURCES := \ + $(filter-out test/addons/??_*/*.cc, $(wildcard test/addons/*/*.cc)) \ + $(filter-out test/addons/??_*/*.h, $(wildcard test/addons/*/*.h)) \ + # Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale. # Depends on node-gyp package.json so that build-addons is (re)executed when # node-gyp is updated as part of an npm update. test/addons/.buildstamp: deps/npm/node_modules/node-gyp/package.json \ - $(ADDONS_BINDING_GYPS) \ + $(ADDONS_BINDING_GYPS) $(ADDONS_BINDING_SOURCES) \ deps/uv/include/*.h deps/v8/include/*.h \ src/node.h src/node_buffer.h src/node_object_wrap.h \ test/addons/.docbuildstamp