Browse Source

node: set process._eventsCount to 0 on startup

process is an EventEmitter. There are operations that increment and
decrement the _eventsCount property of an EventEmitter.
process._eventsCount would previously get set to NaN. This change makes
process._eventsCount be calculated as expected.

PR-URL: https://github.com/nodejs/node/pull/5208
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
v5.x
Evan Lucas 9 years ago
committed by Rod Vagg
parent
commit
9cee86e3e9
  1. 1
      src/node.js
  2. 2
      test/parallel/test-process-emit.js

1
src/node.js

@ -12,6 +12,7 @@
function startup() {
var EventEmitter = NativeModule.require('events');
process._eventsCount = 0;
Object.setPrototypeOf(process, Object.create(EventEmitter.prototype, {
constructor: {

2
test/parallel/test-process-emit.js

@ -18,3 +18,5 @@ process.on('SIGPIPE', common.mustCall((data) => {
process.emit('normal', 'normalData');
process.emit(sym, 'symbolData');
process.emit('SIGPIPE', 'signalData');
assert.strictEqual(isNaN(process._eventsCount), false);

Loading…
Cancel
Save