From 9e1eb361e8deb3f296a3c9d01de8fcc10361443f Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 1 Aug 2013 16:09:42 +0200 Subject: [PATCH] test: future-proof simple/test-event-emitter-memory-leak Run the garbage collector before running the actual test. It doesn't matter now but if in the future something in node.js core creates a lot of reclaimable garbage, that will break the test's expectation. --- test/simple/test-event-emitter-memory-leak.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/simple/test-event-emitter-memory-leak.js b/test/simple/test-event-emitter-memory-leak.js index d02fa80512..2cb56124cd 100644 --- a/test/simple/test-event-emitter-memory-leak.js +++ b/test/simple/test-event-emitter-memory-leak.js @@ -28,6 +28,8 @@ var assert = require('assert'); var events = require('events'); assert.equal(typeof gc, 'function', 'Run this test with --expose-gc'); +gc(); + var before = process.memoryUsage().heapUsed; var e = new events.EventEmitter(); @@ -36,7 +38,7 @@ for (var i = 0; i < 2.5e5; ++i) { e.on(name, assert.fail); e.removeListener(name, assert.fail); } -while (gc()); +gc(); var after = process.memoryUsage().heapUsed; assert(after - before < 1024*1024, 'EventEmitter leaks event names.');