Browse Source

test: performance, remove Popen(shell=True) on Win

not needed according to official python docs -
https://docs.python.org/2/library/subprocess.html#index-2

PR-URL: https://github.com/nodejs/node/pull/12138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
v7.x
Refael Ackermann 8 years ago
committed by Italo A. Casas
parent
commit
9e6b0a4604
No known key found for this signature in database GPG Key ID: 23EFEFE93C4CFFFE
  1. 1
      tools/test.py

1
tools/test.py

@ -616,7 +616,6 @@ def RunProcess(context, timeout, args, **rest):
pty_out = rest.pop('pty_out')
process = subprocess.Popen(
shell = utils.IsWindows(),
args = popen_args,
**rest
)

Loading…
Cancel
Save