Browse Source

benchmark: fix comment typos and code format

I noticed some typos and the lack of {} following an if.

PR-URL: https://github.com/nodejs/node/pull/7961
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
v7.x
Adrian Nitu 9 years ago
committed by Andreas Madsen
parent
commit
9e7fd8e810
  1. 10
      benchmark/common.js
  2. 2
      benchmark/compare.js

10
benchmark/common.js

@ -30,7 +30,7 @@ function Benchmark(fn, options) {
Benchmark.prototype._parseArgs = function(argv, options) {
const cliOptions = Object.assign({}, options);
// Parse configuarion arguments
// Parse configuration arguments
for (const arg of argv) {
const match = arg.match(/^(.+?)=([\s\S]*)$/);
if (!match || !match[1]) {
@ -52,7 +52,7 @@ Benchmark.prototype._queue = function(options) {
const queue = [];
const keys = Object.keys(options);
// Perform a depth-first walk though all options to genereate a
// Perform a depth-first walk though all options to generate a
// configuration list that contains all combinations.
function recursive(keyIndex, prevConfig) {
const key = keys[keyIndex];
@ -171,9 +171,9 @@ Benchmark.prototype._run = function() {
};
Benchmark.prototype.start = function() {
if (this._started)
if (this._started) {
throw new Error('Called start more than once in a single benchmark');
}
this._started = true;
this._time = process.hrtime();
};
@ -195,7 +195,7 @@ Benchmark.prototype.end = function(operations) {
};
function formatResult(data) {
// Construct confiuration string, " A=a, B=b, ..."
// Construct configuration string, " A=a, B=b, ..."
let conf = '';
for (const key of Object.keys(data.conf)) {
conf += ' ' + key + '=' + JSON.stringify(data.conf[key]);

2
benchmark/compare.js

@ -65,7 +65,7 @@ console.log('"binary", "filename", "configuration", "rate", "time"');
}
conf = conf.slice(1);
// Escape qoutes (") for correct csv formatting
// Escape quotes (") for correct csv formatting
conf = conf.replace(/"/g, '""');
console.log(`"${job.binary}", "${job.filename}", "${conf}", ` +

Loading…
Cancel
Save