From 9eddaebb79ff1954b7ecdb209587d7db6554580d Mon Sep 17 00:00:00 2001 From: Nathan Rajlich Date: Wed, 25 Jul 2012 10:34:13 -0700 Subject: [PATCH] assert: remove unnecessary use of __proto__ AssertionError already inherits from Error above using util.inherits(), so this extra line was redundant. test/simple/test-assert.js already tests for `instanceof`, and still passes. --- lib/assert.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/assert.js b/lib/assert.js index 7e932be14a..50a6920a23 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -49,6 +49,8 @@ assert.AssertionError = function AssertionError(options) { Error.captureStackTrace(this, stackStartFunction); } }; + +// assert.AssertionError instanceof Error util.inherits(assert.AssertionError, Error); function replacer(key, value) { @@ -85,10 +87,6 @@ assert.AssertionError.prototype.toString = function() { } }; -// assert.AssertionError instanceof Error - -assert.AssertionError.__proto__ = Error.prototype; - // At present only the three keys mentioned above are used and // understood by the spec. Implementations or sub modules can pass // other keys to the AssertionError's constructor - they will be