Browse Source

test: don't connect to :: (use localhost instead)

If a test does http.listen(0) or net.listen(0),
http.listen(0).address().address returns '::'. Some machines will
resolve this to localhost, but not all. Every machine should have
localhost defined in /etc/hosts (or equivalent), so it should always
resolve.

Fixes: https://github.com/nodejs/node/issues/7291
PR-URL: https://github.com/nodejs/node/pull/10854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
v6.x
Gibson Fahnestock 8 years ago
committed by Myles Borins
parent
commit
a08c7f6d87
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 2
      test/gc/test-net-timeout.js
  2. 4
      test/parallel/test-http-status-reason-invalid-chars.js

2
test/gc/test-net-timeout.js

@ -36,7 +36,7 @@ function getall() {
if (count >= todo)
return;
const req = net.connect(server.address().port, server.address().address);
const req = net.connect(server.address().port);
req.resume();
req.setTimeout(10, function() {
req.destroy();

4
test/parallel/test-http-status-reason-invalid-chars.js

@ -3,7 +3,6 @@
const common = require('../common');
const assert = require('assert');
const http = require('http');
const net = require('net');
function explicit(req, res) {
assert.throws(() => {
@ -34,8 +33,7 @@ const server = http.createServer((req, res) => {
implicit(req, res);
}
}).listen(0, common.mustCall(() => {
const addr = server.address().address;
const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr;
const hostname = 'localhost';
const url = `http://${hostname}:${server.address().port}`;
let left = 2;
const check = common.mustCall((res) => {

Loading…
Cancel
Save