From a1564b7ee77f011450e5ed7080e9963f9a892946 Mon Sep 17 00:00:00 2001 From: Peter Marshall Date: Mon, 18 Sep 2017 13:20:47 +0200 Subject: [PATCH] [HACK] Remove runtime flag for typed array threshold --- configure | 3 +++ src/node.cc | 6 ------ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/configure b/configure index 7fbabdbb26..d4f3aa3477 100755 --- a/configure +++ b/configure @@ -1001,6 +1001,9 @@ def configure_v8(o): o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8) o['variables']['force_dynamic_crt'] = 1 if options.shared else 0 o['variables']['node_enable_d8'] = b(options.enable_d8) + # Unconditionally force typed arrays to allocate outside the v8 heap. This + # is to prevent memory pointers from being moved around that are returned by + # Buffer::Data(). o['variables']['v8_typed_array_max_size_in_heap'] = 0 if options.enable_d8: o['variables']['test_isolation_mode'] = 'noop' # Needed by d8.gyp. diff --git a/src/node.cc b/src/node.cc index 35db43a178..d050bb3fec 100644 --- a/src/node.cc +++ b/src/node.cc @@ -4560,12 +4560,6 @@ void Init(int* argc, } #endif - // Unconditionally force typed arrays to allocate outside the v8 heap. This - // is to prevent memory pointers from being moved around that are returned by - // Buffer::Data(). - const char no_typed_array_heap[] = "--typed_array_max_size_in_heap=0"; - V8::SetFlagsFromString(no_typed_array_heap, sizeof(no_typed_array_heap) - 1); - // We should set node_is_initialized here instead of in node::Start, // otherwise embedders using node::Init to initialize everything will not be // able to set it and native modules will not load for them.