From a172b7c51ec31d18d055889048dd5432bdd01d55 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 1 Sep 2017 17:30:10 -0700 Subject: [PATCH] test: refactor test-debug-prompt MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Use cleaner `process.stdin.write('.exit')` to exit the process rather than `proc.kill()`. * Move test to sequential. It uses the default port 9229. It will fail if another inspector test (or test using port 0) is already using that port. So it needs to be run sequentially rather than in parallel with other tests. (We haven't seen many failures with it yet because there aren't a lot of other inspector tests in parallel at this time.) PR-URL: https://github.com/nodejs/node/pull/15141 Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yuta Hiroto Reviewed-By: Michaël Zasso Reviewed-By: James M Snell --- test/{parallel => sequential}/test-debug-prompt.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename test/{parallel => sequential}/test-debug-prompt.js (90%) diff --git a/test/parallel/test-debug-prompt.js b/test/sequential/test-debug-prompt.js similarity index 90% rename from test/parallel/test-debug-prompt.js rename to test/sequential/test-debug-prompt.js index 81e579ed1e..902bce34fc 100644 --- a/test/parallel/test-debug-prompt.js +++ b/test/sequential/test-debug-prompt.js @@ -11,5 +11,5 @@ let output = ''; proc.stdout.on('data', (data) => { output += data; if (output.includes('debug> ')) - proc.kill(); + proc.stdin.write('.exit\n'); });