Browse Source

test: remove flaky designation for test on AIX

https://github.com/nodejs/node/issues/5085 has been completed so
presumably test-fs-watch is not flaky on AIX anymore. Remove flaky
designation from sequential.status.

PR-URL: https://github.com/nodejs/node/pull/12564
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
v6.x
Rich Trott 8 years ago
committed by Myles Borins
parent
commit
a1de1abcdd
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 5
      test/sequential/sequential.status
  2. 5
      test/sequential/test-fs-watch.js

5
test/sequential/sequential.status

@ -16,9 +16,4 @@ prefix sequential
[$system==freebsd]
# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix]
test-fs-watch : FAIL,PASS

5
test/sequential/test-fs-watch.js

@ -6,7 +6,8 @@ const fs = require('fs');
const expectFilePath = common.isWindows ||
common.isLinux ||
common.isOSX;
common.isOSX ||
common.isAix;
let watchSeenOne = 0;
let watchSeenTwo = 0;
@ -80,7 +81,7 @@ const filepathThree = path.join(testsubdir, filenameThree);
assert.doesNotThrow(
function() {
const watcher = fs.watch(testsubdir, function(event, filename) {
const renameEv = common.isSunOS ? 'change' : 'rename';
const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
assert.strictEqual(renameEv, event);
if (expectFilePath) {
assert.strictEqual(filename, 'newfile.txt');

Loading…
Cancel
Save