From a5012a04ba2baa1e45ad78abbf5c8e14b4d738e8 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 28 Apr 2016 23:43:02 +0200 Subject: [PATCH] build: unbreak -prof, disable PIE on OS X Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7") unwittingly turned on new ASLR features that make `-prof` unusable for profiling C++ code, breaking `test/parallel/test-tick-processor.js` in the process. Build with `-Wl,-no_pie` for now. Fixes: https://github.com/nodejs/node/issues/5903 PR-URL: https://github.com/nodejs/node/pull/6453 Reviewed-By: Fedor Indutny Reviewed-By: James M Snell Reviewed-By: Anna Henningsen --- common.gypi | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 4174e8c362..10da7abccc 100644 --- a/common.gypi +++ b/common.gypi @@ -325,7 +325,12 @@ }, 'target_conditions': [ ['_type!="static_library"', { - 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']}, + 'xcode_settings': { + 'OTHER_LDFLAGS': [ + '-Wl,-no_pie', + '-Wl,-search_paths_first', + ], + }, }], ], 'conditions': [