Browse Source

fs.Stats.size V8::Integer => V8::Number.

While VM::Integer::Value() offers an int64_t, V8::Integer::New() only
accepts an int32_t, truncating fs.Stat's size in BuildStatsObject().

I consider this a bug in V8, and we should move back to V8::Integer
when it gets a ctr that allows a int64_t. Until then, this work-around
should hold.
v0.7.4-release
rentzsch 15 years ago
committed by Ryan Dahl
parent
commit
a5b132ad63
  1. 2
      src/node.cc

2
src/node.cc

@ -928,7 +928,7 @@ Local<Object> BuildStatsObject(struct stat * s) {
stats->Set(rdev_symbol, Integer::New(s->st_rdev));
/* total size, in bytes */
stats->Set(size_symbol, Integer::New(s->st_size));
stats->Set(size_symbol, Number::New(s->st_size));
/* blocksize for filesystem I/O */
stats->Set(blksize_symbol, Integer::New(s->st_blksize));

Loading…
Cancel
Save