From a89deb9c595126b5c15f024e05115b5100f83e29 Mon Sep 17 00:00:00 2001 From: Yevgen Safronov Date: Sat, 17 Sep 2016 10:22:42 +0200 Subject: [PATCH] test: cleanup test-c-ares.js Replace equal with strictEqual, use const instead of var Replace throw error with assert.ifError PR-URL: https://github.com/nodejs/node/pull/8577 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Ilkka Myller --- test/parallel/test-c-ares.js | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/test/parallel/test-c-ares.js b/test/parallel/test-c-ares.js index 66ae0e0a4a..0da5d5210c 100644 --- a/test/parallel/test-c-ares.js +++ b/test/parallel/test-c-ares.js @@ -1,26 +1,26 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); +const common = require('../common'); +const assert = require('assert'); -var dns = require('dns'); +const dns = require('dns'); // Try resolution without callback -dns.lookup(null, function(error, result, addressType) { - assert.equal(null, result); - assert.equal(4, addressType); -}); +dns.lookup(null, common.mustCall(function(error, result, addressType) { + assert.strictEqual(null, result); + assert.strictEqual(4, addressType); +})); -dns.lookup('127.0.0.1', function(error, result, addressType) { - assert.equal('127.0.0.1', result); - assert.equal(4, addressType); -}); +dns.lookup('127.0.0.1', common.mustCall(function(error, result, addressType) { + assert.strictEqual('127.0.0.1', result); + assert.strictEqual(4, addressType); +})); -dns.lookup('::1', function(error, result, addressType) { - assert.equal('::1', result); - assert.equal(6, addressType); -}); +dns.lookup('::1', common.mustCall(function(error, result, addressType) { + assert.strictEqual('::1', result); + assert.strictEqual(6, addressType); +})); // Try calling resolve with an unsupported type. assert.throws(function() { @@ -36,8 +36,8 @@ assert.throws(function() { // C:\Windows\System32\drivers\etc\hosts // so we disable this test on Windows. if (!common.isWindows) { - dns.reverse('127.0.0.1', function(error, domains) { - if (error) throw error; + dns.reverse('127.0.0.1', common.mustCall(function(error, domains) { + assert.ifError(error); assert.ok(Array.isArray(domains)); - }); + })); }