Browse Source

test: rearrange inspector headers into convention

Test guide describes a conventional layout for test headers, review
inspector tests and reorganize to follow the convention.

PR-URL: https://github.com/nodejs/node/pull/13428
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
v6
Sam Roberts 8 years ago
parent
commit
aae0d4559c
  1. 2
      test/inspector/test-inspector-debug-brk.js
  2. 1
      test/inspector/test-inspector-ip-detection.js
  3. 3
      test/inspector/test-inspector-port-zero-cluster.js
  4. 3
      test/inspector/test-inspector-port-zero.js
  5. 1
      test/inspector/test-inspector-stops-no-file.js
  6. 2
      test/inspector/test-inspector.js
  7. 2
      test/parallel/test-cluster-inspector-debug-port.js
  8. 7
      test/parallel/test-inspector-invalid-args.js

2
test/inspector/test-inspector-debug-brk.js

@ -1,6 +1,8 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
common.skipIfInspectorDisabled(); common.skipIfInspectorDisabled();
const assert = require('assert'); const assert = require('assert');
const helper = require('./inspector-helper.js'); const helper = require('./inspector-helper.js');

1
test/inspector/test-inspector-ip-detection.js

@ -1,5 +1,6 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
common.skipIfInspectorDisabled(); common.skipIfInspectorDisabled();
const assert = require('assert'); const assert = require('assert');

3
test/inspector/test-inspector-port-zero-cluster.js

@ -1,8 +1,9 @@
// Flags: --inspect=0 // Flags: --inspect=0
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
common.skipIfInspectorDisabled(); common.skipIfInspectorDisabled();
const assert = require('assert'); const assert = require('assert');
const cluster = require('cluster'); const cluster = require('cluster');

3
test/inspector/test-inspector-port-zero.js

@ -1,7 +1,8 @@
'use strict'; 'use strict';
const { mustCall, skipIfInspectorDisabled } = require('../common'); const { mustCall, skipIfInspectorDisabled } = require('../common');
skipIfInspectorDisabled(); skipIfInspectorDisabled();
const assert = require('assert'); const assert = require('assert');
const { URL } = require('url'); const { URL } = require('url');
const { spawn } = require('child_process'); const { spawn } = require('child_process');

1
test/inspector/test-inspector-stops-no-file.js

@ -1,5 +1,6 @@
'use strict'; 'use strict';
require('../common'); require('../common');
const spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
const child = spawn(process.execPath, const child = spawn(process.execPath,

2
test/inspector/test-inspector.js

@ -1,6 +1,8 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
common.skipIfInspectorDisabled(); common.skipIfInspectorDisabled();
const assert = require('assert'); const assert = require('assert');
const helper = require('./inspector-helper.js'); const helper = require('./inspector-helper.js');

2
test/parallel/test-cluster-inspector-debug-port.js

@ -1,7 +1,9 @@
'use strict'; 'use strict';
// Flags: --inspect={PORT} // Flags: --inspect={PORT}
const common = require('../common'); const common = require('../common');
common.skipIfInspectorDisabled(); common.skipIfInspectorDisabled();
const assert = require('assert'); const assert = require('assert');
const cluster = require('cluster'); const cluster = require('cluster');
const debuggerPort = common.PORT; const debuggerPort = common.PORT;

7
test/parallel/test-inspector-invalid-args.js

@ -1,11 +1,12 @@
'use strict'; 'use strict';
const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert'); const assert = require('assert');
const execFile = require('child_process').execFile; const execFile = require('child_process').execFile;
const path = require('path'); const path = require('path');
const common = require('../common');
common.skipIfInspectorDisabled();
const mainScript = path.join(common.fixturesDir, 'loop.js'); const mainScript = path.join(common.fixturesDir, 'loop.js');
const expected = const expected =
'`node --debug` and `node --debug-brk` are invalid. ' + '`node --debug` and `node --debug-brk` are invalid. ' +

Loading…
Cancel
Save