Browse Source

Add remoteAddress and remotePort for client TCP connections

https://groups.google.com/d/topic/nodejs-dev/Asr87_YFSkg/discussion
v0.7.4-release
Brian White 14 years ago
committed by Ryan Dahl
parent
commit
ac1da4b407
  1. 6
      doc/api/net.markdown
  2. 2
      lib/net.js
  3. 33
      test/simple/test-net-remote-address-port.js

6
doc/api/net.markdown

@ -303,7 +303,11 @@ initialDelay will leave the value unchanged from the default
The string representation of the remote IP address. For example, The string representation of the remote IP address. For example,
`'74.125.127.100'` or `'2001:4860:a005::68'`. `'74.125.127.100'` or `'2001:4860:a005::68'`.
This member is only present in server-side connections. #### socket.remotePort
The numeric representation of the remote port. For example,
`80` or `21`.
#### Event: 'connect' #### Event: 'connect'

2
lib/net.js

@ -719,6 +719,8 @@ Socket.prototype.connect = function() {
timers.active(self); timers.active(self);
self.type = addressType == 4 ? 'tcp4' : 'tcp6'; self.type = addressType == 4 ? 'tcp4' : 'tcp6';
self.fd = socket(self.type); self.fd = socket(self.type);
self.remoteAddress = ip;
self.remotePort = port;
doConnect(self, port, ip); doConnect(self, port, ip);
} }
}); });

33
test/simple/test-net-remote-address-port.js

@ -0,0 +1,33 @@
var common = require('../common');
var assert = require('assert');
var net = require('net');
var conns = 0;
var server = net.createServer(function(socket) {
conns++;
assert.equal('127.0.0.1', socket.remoteAddress);
socket.on('end', function() {
server.close();
});
});
server.listen(common.PORT, 'localhost', function() {
var client = net.createConnection(common.PORT, 'localhost');
var client2 = net.createConnection(common.PORT);
client.on('connect', function() {
assert.equal('127.0.0.1', client.remoteAddress);
assert.equal(common.PORT, client.remotePort);
client.end();
});
client2.on('connect', function() {
assert.equal('127.0.0.1', client2.remoteAddress);
assert.equal(common.PORT, client2.remotePort);
client2.end();
});
});
process.exit(function() {
assert.equal(2, conns);
});
Loading…
Cancel
Save