mirror of https://github.com/lukechilds/node.git
Browse Source
Original commit message: Improved diagnostic message for JS heap out of memory This patch replaces the unused 'take_snapshot' parameter on FatalProcessOutOfMemory() with a 'is_heap_oom' parameter. The parameter is set to true on error paths where the JS heap is out of memory, as distinct from a malloc() failure i.e. process out of memory. The message output to stderr or passed to embedding applications via FatalErrorCallback is 'Javascript heap out of memory' rather than 'process out of memory'. BUG= R=jochen@chromium.org, verwaest@chromium.org, michael_dawson@ca.ibm.com Review URL: https://codereview.chromium.org/1873443002 Cr-Commit-Position: refs/heads/master@{#35431} We'd like this in 6.x to help with diagnosing customer problems. It provides a better message on OOM so that it is easier to be able to tell whether the OOM was due to heap exhaustion or running out of native memory. PR-URL: https://github.com/nodejs/node/pull/6218 Reviewed-By: Ben Noordhuis <ben@strongloop.com> Reviewed-By: James M Snell <jasnell@gmail.com>process-exit-stdio-flushing
Michael Dawson
9 years ago
5 changed files with 11 additions and 11 deletions
Loading…
Reference in new issue