Browse Source

test: remove uses of common.PORT in test-tls-client tests

Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: https://github.com/nodejs/node/pull/12461
Ref: https://github.com/nodejs/node/issues/12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
v6.x
Ahmed Taj elsir 8 years ago
committed by Myles Borins
parent
commit
b1d26d8b55
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 4
      test/parallel/test-tls-client-abort.js
  2. 2
      test/parallel/test-tls-client-abort2.js

4
test/parallel/test-tls-client-abort.js

@ -14,9 +14,7 @@ const path = require('path');
const cert = fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'));
const key = fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem'));
const conn = tls.connect({cert: cert, key: key, port: common.PORT}, function() {
assert.ok(false); // callback should never be executed
});
const conn = tls.connect({cert, key, port: 0}, common.mustNotCall());
conn.on('error', function() {
});
assert.doesNotThrow(function() {

2
test/parallel/test-tls-client-abort2.js

@ -8,7 +8,7 @@ if (!common.hasCrypto) {
}
const tls = require('tls');
const conn = tls.connect(common.PORT, common.mustNotCall());
const conn = tls.connect(0, common.mustNotCall());
conn.on('error', common.mustCall(function() {
assert.doesNotThrow(function() {
conn.destroy();

Loading…
Cancel
Save