Browse Source

src: add node::FreeEnvironment public API

Since debugger::Agent's interface is not exported, third party embedders
will have linking errors if they call Environment's destructor directly.

PR-URL: https://github.com/nodejs/node/pull/3098
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
v4.x
Cheng Zhao 10 years ago
committed by Myles Borins
parent
commit
b21d145c2a
  1. 7
      src/node.cc
  2. 1
      src/node.h

7
src/node.cc

@ -3226,6 +3226,13 @@ void LoadEnvironment(Environment* env) {
f->Call(global, 1, &arg); f->Call(global, 1, &arg);
} }
void FreeEnvironment(Environment* env) {
CHECK_NE(env, nullptr);
env->Dispose();
}
static void PrintHelp(); static void PrintHelp();
static bool ParseDebugOpt(const char* arg) { static bool ParseDebugOpt(const char* arg) {

1
src/node.h

@ -196,6 +196,7 @@ NODE_EXTERN Environment* CreateEnvironment(v8::Isolate* isolate,
int exec_argc, int exec_argc,
const char* const* exec_argv); const char* const* exec_argv);
NODE_EXTERN void LoadEnvironment(Environment* env); NODE_EXTERN void LoadEnvironment(Environment* env);
NODE_EXTERN void FreeEnvironment(Environment* env);
// NOTE: Calling this is the same as calling // NOTE: Calling this is the same as calling
// CreateEnvironment() + LoadEnvironment() from above. // CreateEnvironment() + LoadEnvironment() from above.

Loading…
Cancel
Save