From b24cdb3d362bd88e4a6486a589e9fb6c498f360b Mon Sep 17 00:00:00 2001 From: Igor Zinkovsky Date: Thu, 8 Dec 2011 15:00:48 -0800 Subject: [PATCH] Enable upgrades in MSI. Fixes #2228. --- tools/msvs/msi/nodemsi.wixproj | 4 ++-- tools/msvs/msi/product.wxs | 5 ++++- vcbuild.bat | 4 +++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/msvs/msi/nodemsi.wixproj b/tools/msvs/msi/nodemsi.wixproj index e45372457b..96813d3b8e 100644 --- a/tools/msvs/msi/nodemsi.wixproj +++ b/tools/msvs/msi/nodemsi.wixproj @@ -16,12 +16,12 @@ ..\..\..\$(Configuration)\ obj\$(Configuration)\ - Debug;ProductVersion=$(NodeVersion);NPMSourceDir=..\..\..\deps\npm\ + Debug;ProductVersion=$(NodeVersion);ProductId=$(NodeProductId);NPMSourceDir=..\..\..\deps\npm\ ..\..\..\$(Configuration)\ obj\$(Configuration)\ - Debug;ProductVersion=$(NodeVersion);NPMSourceDir=..\..\..\deps\npm\ + Debug;ProductVersion=$(NodeVersion);ProductId=$(NodeProductId);NPMSourceDir=..\..\..\deps\npm\ diff --git a/tools/msvs/msi/product.wxs b/tools/msvs/msi/product.wxs index d924a4dfef..b8b53b0be4 100644 --- a/tools/msvs/msi/product.wxs +++ b/tools/msvs/msi/product.wxs @@ -4,7 +4,7 @@ - + + diff --git a/vcbuild.bat b/vcbuild.bat index 38a1951b92..290e5239a3 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -89,7 +89,9 @@ python "%~dp0tools\getnodeversion.py" > "%temp%\node_version.txt" if not errorlevel 0 echo Cannot determine current version of node.js & goto exit for /F "tokens=*" %%i in (%temp%\node_version.txt) do set NODE_VERSION=%%i heat dir deps\npm -var var.NPMSourceDir -dr NodeModulesFolder -cg NPMFiles -gg -template fragment -nologo -out npm.wxs -msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /t:Clean,Build /p:Configuration=%config% /p:NodeVersion=%NODE_VERSION% /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo +uuidgen > "%temp%\node_product_id.txt" +set /p NODE_PRODUCT_ID=<"%temp%\node_product_id.txt" +msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /t:Clean,Build /p:Configuration=%config% /p:NodeVersion=%NODE_VERSION% /p:NodeProductId=%NODE_PRODUCT_ID% /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo if errorlevel 1 goto exit if defined nosign goto run