Browse Source

http2: fix [kInspect]() output for Http2Stream

This fixes a typo in the util.inspect output of Http2Stream. It
previously had writeableSate instead of writableState.

PR-URL: https://github.com/nodejs/node/pull/14753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
v6
Evan Lucas 8 years ago
parent
commit
b2a9b81738
  1. 2
      lib/internal/http2/core.js
  2. 29
      test/parallel/test-http2-stream-client.js

2
lib/internal/http2/core.js

@ -1315,7 +1315,7 @@ class Http2Stream extends Duplex {
id: this[kID],
state: this.state,
readableState: this._readableState,
writeableSate: this._writableState
writableState: this._writableState
};
return `Http2Stream ${util.format(obj)}`;
}

29
test/parallel/test-http2-stream-client.js

@ -0,0 +1,29 @@
// Flags: --expose-http2
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const util = require('util');
const server = http2.createServer();
server.on('stream', common.mustCall((stream) => {
assert.strictEqual(stream.aborted, false);
const insp = util.inspect(stream);
assert.ok(/Http2Stream { id/.test(insp));
assert.ok(/ state:/.test(insp));
assert.ok(/ readableState:/.test(insp));
assert.ok(/ writableState:/.test(insp));
stream.end('ok');
}));
server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
const req = client.request();
req.resume();
req.on('streamClosed', common.mustCall(() => {
client.destroy();
server.close();
}));
}));
Loading…
Cancel
Save