From b3bc009a89d605ab89d28857d19fea0975040b58 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Tue, 9 Aug 2011 17:59:26 -0700 Subject: [PATCH] Fix test-net-server-on-fd-0 for windows by removing assert Rename to regression test for GH-746 as the fd 0 behavior was not what the bug report was about. --- Makefile | 1 + .../{test-net-server-on-fd-0.js => test-regress-GH-746.js} | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) rename test/simple/{test-net-server-on-fd-0.js => test-regress-GH-746.js} (93%) diff --git a/Makefile b/Makefile index 204cca0a26..e6fd054b60 100644 --- a/Makefile +++ b/Makefile @@ -185,6 +185,7 @@ UVTEST += simple/test-readdouble UVTEST += simple/test-readfloat UVTEST += simple/test-readint UVTEST += simple/test-readuint +UVTEST += simple/test-regress-GH-746 UVTEST += simple/test-regress-GH-819 UVTEST += simple/test-regress-GH-897 UVTEST += simple/test-regression-object-prototype diff --git a/test/simple/test-net-server-on-fd-0.js b/test/simple/test-regress-GH-746.js similarity index 93% rename from test/simple/test-net-server-on-fd-0.js rename to test/simple/test-regress-GH-746.js index 21b73c8717..29f1456522 100644 --- a/test/simple/test-net-server-on-fd-0.js +++ b/test/simple/test-regress-GH-746.js @@ -19,6 +19,9 @@ // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // USE OR OTHER DEALINGS IN THE SOFTWARE. +// Just test that destroying stdin doesn't mess up listening on a server. +// This is a regression test for GH-746. + var common = require('../common'); var assert = require('assert'); var net = require('net'); @@ -36,7 +39,6 @@ var server = net.createServer(function(socket) { server.listen(common.PORT, function() { console.log('listening...'); - assert.equal(server.fd, 0); net.createConnection(common.PORT); });