Browse Source

Parse the command line before initializing V8.

Doing it the other way around means that V8 won't pick
up command line switches like `--prof`.

Props to Joshua Kehn for reporting the issue and Jeff Fifield
for pointing out the cause.

Fixes #900.
Fixes #1217.
v0.7.4-release
Ben Noordhuis 14 years ago
committed by Ryan Dahl
parent
commit
b74d119b34
  1. 6
      src/node.cc

6
src/node.cc

@ -2486,11 +2486,13 @@ void EmitExit(v8::Handle<v8::Object> process) {
int Start(int argc, char *argv[]) { int Start(int argc, char *argv[]) {
uv_init(); uv_init();
v8::V8::Initialize();
v8::HandleScope handle_scope;
// This needs to run *before* V8::Initialize()
argv = Init(argc, argv); argv = Init(argc, argv);
v8::V8::Initialize();
v8::HandleScope handle_scope;
// Create the one and only Context. // Create the one and only Context.
Persistent<v8::Context> context = v8::Context::New(); Persistent<v8::Context> context = v8::Context::New();
v8::Context::Scope context_scope(context); v8::Context::Scope context_scope(context);

Loading…
Cancel
Save