Browse Source

test: replace `indexOf` with `includes`

PR-URL: https://github.com/nodejs/node/pull/13215
Refs: https://github.com/nodejs/node/issues/12586
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
v6.x
Aditya Anand 8 years ago
committed by Myles Borins
parent
commit
b793fc6cf6
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 3
      test/parallel/test-http-client-agent.js
  2. 6
      test/parallel/test-http-client-default-headers-exist.js

3
test/parallel/test-http-client-agent.js

@ -34,7 +34,8 @@ function request(i) {
socket.on('close', function() {
++count;
if (count < max) {
assert.strictEqual(http.globalAgent.sockets[name].indexOf(socket), -1);
assert.strictEqual(http.globalAgent.sockets[name].includes(socket),
false);
} else {
assert(!http.globalAgent.sockets.hasOwnProperty(name));
assert(!http.globalAgent.requests.hasOwnProperty(name));

6
test/parallel/test-http-client-default-headers-exist.js

@ -25,9 +25,9 @@ const server = http.createServer(function(req, res) {
const requestHeaders = Object.keys(req.headers);
requestHeaders.forEach(function(header) {
assert.notStrictEqual(
expectedHeaders[req.method].indexOf(header.toLowerCase()),
-1,
assert.strictEqual(
expectedHeaders[req.method].includes(header.toLowerCase()),
true,
`${header} should not exist for method ${req.method}`
);
});

Loading…
Cancel
Save