Browse Source

process_wrap: omit superfluous Number creation

Don't create a superfluous Number object, just use the version of
v8::Object::Get() that takes an unsigned int. Convert the index to
unsigned int while we're here.
v0.11.5-release
Ben Noordhuis 12 years ago
parent
commit
b8a7eedea3
  1. 7
      src/process_wrap.cc

7
src/process_wrap.cc

@ -86,13 +86,12 @@ class ProcessWrap : public HandleWrap {
uv_process_options_t* options) { uv_process_options_t* options) {
Local<Array> stdios = js_options Local<Array> stdios = js_options
->Get(String::NewSymbol("stdio")).As<Array>(); ->Get(String::NewSymbol("stdio")).As<Array>();
int len = stdios->Length(); uint32_t len = stdios->Length();
options->stdio = new uv_stdio_container_t[len]; options->stdio = new uv_stdio_container_t[len];
options->stdio_count = len; options->stdio_count = len;
for (int i = 0; i < len; i++) { for (uint32_t i = 0; i < len; i++) {
Local<Object> stdio = stdios Local<Object> stdio = stdios->Get(i).As<Object>();
->Get(Number::New(static_cast<double>(i))).As<Object>();
Local<Value> type = stdio->Get(String::NewSymbol("type")); Local<Value> type = stdio->Get(String::NewSymbol("type"));
if (type->Equals(String::NewSymbol("ignore"))) { if (type->Equals(String::NewSymbol("ignore"))) {

Loading…
Cancel
Save