Browse Source

vm: don't abort process when stack space runs out

Make less assumptions about what objects will be available when
vm context creation or error message printing fail because V8
runs out of JS stack space.

Ref: https://github.com/nodejs/node/issues/6899
PR-URL: https://github.com/nodejs/node/pull/6907
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
v4.x
Anna Henningsen 9 years ago
committed by Myles Borins
parent
commit
b9dfdfe1d3
  1. 6
      src/node_contextify.cc
  2. 26
      test/parallel/test-vm-low-stack-space.js

6
src/node_contextify.cc

@ -205,7 +205,11 @@ class ContextifyContext {
Local<Context> ctx = Context::New(env->isolate(), nullptr, object_template); Local<Context> ctx = Context::New(env->isolate(), nullptr, object_template);
CHECK(!ctx.IsEmpty()); if (ctx.IsEmpty()) {
env->ThrowError("Could not instantiate context");
return Local<Context>();
}
ctx->SetSecurityToken(env->context()->GetSecurityToken()); ctx->SetSecurityToken(env->context()->GetSecurityToken());
// We need to tie the lifetime of the sandbox object with the lifetime of // We need to tie the lifetime of the sandbox object with the lifetime of

26
test/parallel/test-vm-low-stack-space.js

@ -0,0 +1,26 @@
'use strict';
require('../common');
const assert = require('assert');
const vm = require('vm');
function a() {
try {
return a();
} catch (e) {
// Throw an exception as near to the recursion-based RangeError as possible.
return vm.runInThisContext('() => 42')();
}
}
assert.strictEqual(a(), 42);
function b() {
try {
return b();
} catch (e) {
// This writes a lot of noise to stderr, but it still works.
return vm.runInNewContext('() => 42')();
}
}
assert.strictEqual(b(), 42);
Loading…
Cancel
Save