Browse Source

tls: do not default to 'localhost' servername

Fedor Indutny 11 years ago
parent
commit
ba7c9ce964
  1. 3
      lib/_tls_wrap.js
  2. 2
      src/node_crypto.cc

3
lib/_tls_wrap.js

@ -685,8 +685,7 @@ exports.connect = function(/* [port, host], options, cb */) {
var hostname = options.servername ||
options.host ||
options.socket && options.socket._host ||
'localhost',
options.socket && options.socket._host,
NPN = {},
credentials = crypto.createCredentials(options);
tls.convertNPNProtocols(options.NPNProtocols, NPN);

2
src/node_crypto.cc

@ -1710,7 +1710,7 @@ void Connection::New(const FunctionCallbackInfo<Value>& args) {
#ifdef SSL_CTRL_SET_TLSEXT_SERVERNAME_CB
if (is_server) {
SSL_CTX_set_tlsext_servername_callback(sc->ctx_, SelectSNIContextCallback_);
} else {
} else if (args[2]->IsString()) {
const String::Utf8Value servername(args[2]);
SSL_set_tlsext_host_name(conn->ssl_, *servername);
}

Loading…
Cancel
Save