Browse Source

test: fix `fs-watch-recursive` flakiness on OS X

The test is sometimes timing out because of a race condition between
the fs event generated on file creation and the event being registered
in the kqueue. To avoid this problem, create the file after 100 ms,
that is the value used in the `fs_event_watch_dir_recursive` libuv test.

PR-URL: https://github.com/nodejs/node/pull/4629
Reviewed-By: Rich Trott <rtrott@gmail.com>
v6.x
Santiago Gimeno 9 years ago
committed by Jeremiah Senkpiel
parent
commit
c07e063dd9
  1. 8
      test/parallel/test-fs-watch-recursive.js

8
test/parallel/test-fs-watch-recursive.js

@ -34,7 +34,13 @@ watcher.on('change', function(event, filename) {
watcherClosed = true;
});
fs.writeFileSync(filepathOne, 'world');
if (process.platform === 'darwin') {
setTimeout(function() {
fs.writeFileSync(filepathOne, 'world');
}, 100);
} else {
fs.writeFileSync(filepathOne, 'world');
}
process.on('exit', function() {
assert(watcherClosed, 'watcher Object was not closed');

Loading…
Cancel
Save