Browse Source

zlib: fix use after null when calling .close

An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: https://github.com/nodejs/node/pull/5982
Fixes: https://github.com/nodejs/node/issues/6034
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
process-exit-stdio-flushing
James Lal 9 years ago
committed by Anna Henningsen
parent
commit
c7fef3d3b8
No known key found for this signature in database GPG Key ID: D8B9F5AEAE84E4CF
  1. 5
      lib/zlib.js

5
lib/zlib.js

@ -474,7 +474,10 @@ function _close(engine, callback) {
engine._closed = true; engine._closed = true;
engine._handle.close(); // Caller may invoke .close after a zlib error (which will null _handle).
if (engine._handle) {
engine._handle.close();
}
} }
function emitCloseNT(self) { function emitCloseNT(self) {

Loading…
Cancel
Save