From caa0d0c0a761cdcc516cd9b7a214e5f05526bb9e Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 20 Aug 2015 22:33:12 +0200 Subject: [PATCH] stream: rename poorly named function roundUpToNextPowerOf2() does more than just rounding up to the next power of two. Rename it to computeNewHighWaterMark(). PR-URL: https://github.com/nodejs/node/pull/2479 Reviewed-By: Chris Dickinson Reviewed-By: Sakthipriyan Vairamani --- lib/_stream_readable.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js index 766577af58..681c3eaec2 100644 --- a/lib/_stream_readable.js +++ b/lib/_stream_readable.js @@ -192,7 +192,7 @@ Readable.prototype.setEncoding = function(enc) { // Don't raise the hwm > 8MB const MAX_HWM = 0x800000; -function roundUpToNextPowerOf2(n) { +function computeNewHighWaterMark(n) { if (n >= MAX_HWM) { n = MAX_HWM; } else { @@ -231,7 +231,7 @@ function howMuchToRead(n, state) { // power of 2, to prevent increasing it excessively in tiny // amounts. if (n > state.highWaterMark) - state.highWaterMark = roundUpToNextPowerOf2(n); + state.highWaterMark = computeNewHighWaterMark(n); // don't have that much. return null, unless we've ended. if (n > state.length) {