crypto: fix CipherFinal return value check

11 years ago · caca4f33aa
1 changed files with 2 additions and 2 deletions
--- a/src/node_crypto.cc
+++ b/src/node_crypto.cc
@ -2478,7 +2478,7 @@ bool CipherBase::Final(unsigned char** out, int *out_len) {
    return false;

  *out = new unsigned char[EVP_CIPHER_CTX_block_size(&ctx_)];
-  bool r = EVP_CipherFinal_ex(&ctx_, *out, out_len);
+  int r = EVP_CipherFinal_ex(&ctx_, *out, out_len);

  if (r && kind_ == kCipher) {
    delete[] auth_tag_;
@ -2497,7 +2497,7 @@ bool CipherBase::Final(unsigned char** out, int *out_len) {
  EVP_CIPHER_CTX_cleanup(&ctx_);
  initialised_ = false;

-  return r;
+  return r == 1;
 }