diff --git a/src/handle_wrap.cc b/src/handle_wrap.cc index 3f05c7d81b..a63421bc29 100644 --- a/src/handle_wrap.cc +++ b/src/handle_wrap.cc @@ -57,7 +57,7 @@ Handle HandleWrap::Ref(const Arguments& args) { UNWRAP_NO_ABORT(HandleWrap) - if (wrap) { + if (wrap != NULL && wrap->handle__ != NULL) { uv_ref(wrap->handle__); wrap->flags_ &= ~kUnref; } @@ -71,7 +71,7 @@ Handle HandleWrap::Unref(const Arguments& args) { UNWRAP_NO_ABORT(HandleWrap) - if (wrap) { + if (wrap != NULL && wrap->handle__ != NULL) { uv_unref(wrap->handle__); wrap->flags_ |= kUnref; } diff --git a/test/simple/test-stdout-close-unref.js b/test/simple/test-stdout-close-unref.js new file mode 100644 index 0000000000..533a005936 --- /dev/null +++ b/test/simple/test-stdout-close-unref.js @@ -0,0 +1,23 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +process.stdout._handle.close(); +process.stdout._handle.unref(); // Should not segfault.