Browse Source

Deprecate sendHeader() and writeHeader(), ppl should use writeHead()

v0.7.4-release
Ryan Dahl 15 years ago
parent
commit
d0128787e7
  1. 28
      lib/http.js

28
lib/http.js

@ -183,8 +183,15 @@ IncomingMessage.prototype._parseQueryString = function () {
throw new Error("_parseQueryString is deprecated. Use require(\"querystring\") to parse query strings.\n"); throw new Error("_parseQueryString is deprecated. Use require(\"querystring\") to parse query strings.\n");
}; };
var setBodyEncodingWarning;
IncomingMessage.prototype.setBodyEncoding = function (enc) { IncomingMessage.prototype.setBodyEncoding = function (enc) {
// TODO deprecation message? // deprecation message
if (!setBodyEncodingWarning) {
setBodyEncodingWarning = "setBodyEncoding has been renamed to setEncoding, please update your code.";
sys.error(setBodyEncodingWarning);
}
this.setEncoding(enc); this.setEncoding(enc);
}; };
@ -446,9 +453,22 @@ ServerResponse.prototype.writeHead = function (statusCode) {
this.headWritten = true; this.headWritten = true;
}; };
// TODO eventually remove sendHeader(), writeHeader() // TODO Eventually remove
ServerResponse.prototype.sendHeader = ServerResponse.prototype.writeHead; var sendHeaderWarning, writeHeaderWarning;
ServerResponse.prototype.writeHeader = ServerResponse.prototype.writeHead; ServerResponse.prototype.sendHeader = function () {
if (!sendHeaderWarning) {
sendHeaderWarning = "sendHeader() has been renamed to writeHead()";
sys.error(sendHeaderWarning);
}
this.writeHead.apply(this, arguments);
};
ServerResponse.prototype.writeHeader = function () {
if (!writeHeaderWarning) {
writeHeaderWarning = "writeHeader() has been renamed to writeHead()";
sys.error(writeHeaderWarning);
}
this.writeHead.apply(this, arguments);
};
function ClientRequest (socket, method, url, headers) { function ClientRequest (socket, method, url, headers) {
OutgoingMessage.call(this, socket); OutgoingMessage.call(this, socket);

Loading…
Cancel
Save